remove dependency for ocm and aws #667
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pvasant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -1758,7 +1758,16 @@ func run(cmd *cobra.Command, _ []string) { | |||
| reporter.Infof("To view a list of clusters and their status, run 'rosa list clusters'") | |||
| } | |||
|
|
|||
| _, err = ocmClient.CreateCluster(clusterConfig) | |||
| // Create the access key for the AWS user: | |||
| awsAccessKey, err := awsClient.GetAWSAccessKeys() | |||
There was a problem hiding this comment.
I think this is going to cause #637 to be unavoidable. Previously STS mode avoided a code path that upserted the credentials. ocm usage with osdCCSadmin then breaks because it depends on those credentials and they need rotating again to actually get them for use.
pvasant
force-pushed
the
removecirculardependencyforocmandawspackage
branch
from
9acba6f
to
0436cd0
Compare
|
@pvasant: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
No description provided.